Open natew opened 1 week ago
Hey @natew! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines.
Hey @autofix-ci[bot]! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines.
Name | Link |
---|---|
Latest commit | d0304ae436389127e56f2592cc00ff15ea647b63 |
Latest deploy log | https://app.netlify.com/sites/react-navigation-example/deploys/6637dfadc261600008972312 |
Deploy Preview | https://deploy-preview-11976--react-navigation-example.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Name | Link |
---|---|
Latest commit | ad8a3782e4325777ee8a6ae7b396c7b9531a5e06 |
Latest deploy log | https://app.netlify.com/sites/react-navigation-example/deploys/6637dff94ac3d10008a8209c |
Deploy Preview | https://deploy-preview-11976--react-navigation-example.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Please provide enough information so that others can review your pull request.
Motivation
I'm using react-navigation with Vite (browser-loaded esm) and this is actually really tricky to fix because imports are always hoisted above code, so my polyfill attempts get pushed below the react-navigation import unless I literally add a script tag above the app entrypoint.
Moving to globalThis should be safe and supported in most node/react-native/browsers from the last few years.
Test plan
I haven't tested thoroughly.