search

react-navigation / redux-helpers

Redux middleware and utils for React Navigation
Other
296 stars 43 forks source link

Fix for https://github.com/infinitered/ignite-andross/issues/291 #100

Closed qtcoder999 closed 5 years ago

qtcoder999 commented 5 years ago

We are facing this issue after migrating to RN 0.59.

This is the main issue where this is discussed.

https://github.com/infinitered/ignite-andross/issues/291

We have taken help from https://github.com/infinitered/ignite-andross/issues/291#issuecomment-535595819 and the issue has got resolved.

The problem is that we have to make changes in the

node_modules/react-navigation-redux-helpers/src/create-redux-container.js

everytime after doing an npm install.

If this PR gets merged, that would save us from the above mentioned repetitive struggle.

Could you please take a look and help us ?

Ashoat commented 5 years ago
  1. As a general rule of thumb you shouldn’t submit opinionated style changes in a PR. You added a whole bunch of whitespace to the Flow annotations.
  2. Your inability to use the ThemeProvider appears to be a simple versioning issue. You’re probably using a new version of react-navigation-redux-helpers with an older version of react-navigation. It probably would’ve more helpful for you to post an issue with the versions you’re using instead of this PR. Either way: the releases tab on this GitHub repo has information on versions and compatibility.
  3. Did you update the types to import from react-navigation on purpose to avoid Flow errors? If so you should instead download the @react-navigation/core libdef.