search

react-navigation / rfcs

RFCs for changes to React Navigation
Other
88 stars 16 forks source link

What versions of React Native should be supported? #30

Open brentvatne opened 6 years ago

brentvatne commented 6 years ago

Should there be some clear rules on what versions we support so users know what to expect? What should those rules be?

dantman commented 6 years ago

Is there a way we can automatically test old versions of RN one by one until we hit the version that doesn't work, then just declare that as the supported version of RN for that release of React Navigation. Then users know they have to update.

And whenever someone makes a PR that happens to break an old version of RN we stick to a policy of "we'll accept the commit as long as it works in the last 3 (or maybe just 2) versions of React Native".

So we'll support RN as far back as it "just works", but as soon as anyone adds code that uses a newer API, we just update our minimum to match.

ericvicenti commented 6 years ago

That’s a cool idea @dantman!

But I’m concerned that there will also be slight issues with older versions that also break compatibility..

On Fri, Mar 9, 2018 at 12:42 PM Daniel Friesen notifications@github.com wrote:

Is there a way we can automatically test old versions of RN one by one until we hit the version that doesn't work, then just declare that as the supported version of RN for that release of React Navigation. Then users know they have to update.

And whenever someone makes a PR that happens to break an old version of RN we stick to a policy of "we'll accept the commit as long as it works in the last 3 (or maybe just 2) versions of React Native".

So we'll support RN as far back as it "just works", but as soon as anyone adds code that uses a newer API, we just update our minimum to match.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/react-navigation/rfcs/issues/30#issuecomment-371939519, or mute the thread https://github.com/notifications/unsubscribe-auth/ABajTfMixUV0PTV4XPKBVDf04YVSR15vks5tcukugaJpZM4Skw3Y .