react-navigation / rfcs

RFCs for changes to React Navigation
Other
88 stars 16 forks source link

navigation.continue / next: push but without passing in a route name #37

Open peterpme opened 6 years ago

peterpme commented 6 years ago

:wave:

Given a stack navigator with the following routes:

{
  Login,
  ConnectGmail,
  Loading,
  Welcome
}

What

I'm proposing a navigation.continue or navigation.next method that will automatically determine the next route in line.

Why

Over the past 6 months we've built different onboarding flows and moving routes around for testing purposes. I have to open up individual files and update to the correct route name.

This isn't the worst thing in the world, but if I could do this at the navigator level it would improve my productivity.

Issues

{
 Login: { key: 0, screen: LoginScreen }
}

How

I would be more than happy to implement this.

Thank you!

ericvicenti commented 6 years ago

‘continue’ seems like a useful feature to add to stack router. Could we make the “order” API match that of tab router? It uses the order of keys in the object by default, which is technically not defined in the JS spec, but usually works nonetheless. The correct way to define it is to explicitly provide the order in the router config

peterpme commented 6 years ago

Of course, thanks! wrt sort order, I figured as much but wanted to bring it up anyway 😄

Do you want a formal RFC pr for this?

satya164 commented 4 years ago

This is interesting feature. With v5, order is derived from the order of Screen elements, so we don't need a separate thing for that.