search

react-navigation / rfcs

RFCs for changes to React Navigation
Other
88 stars 16 forks source link

Event emitter for header button #48

Closed brentvatne closed 4 years ago

brentvatne commented 6 years ago

Works fine in react-native-navigation, we did the same thing in ex-navigation and it was ok too. It certainly doesn't feel ideal but it's better than params.

More in https://github.com/react-navigation/react-navigation/issues/145#issuecomment-396311054

brentvatne commented 6 years ago

fwiw I'm not totally convinced this is needed, we should definitely update the docs to explain the concern that the user had in the comment I linked to above, though. also we should add getParam

satya164 commented 4 years ago

Duplicate of #20