TypeScript Convertion - WIP

react-scheduler / react-big-schedule

React Big Schedule is a powerful and intuitive scheduler and resource planning solution built with React.

https://react-big-schedule.vercel.app/

MIT License

101 stars 23 forks source link

TypeScript Convertion - WIP #150

Open pmm26 opened 2 months ago

pmm26 commented 2 months ago

Changes:

Converted files to TypeScript
Event Start and End date are now dayjs objects instead of date strings.
Event Items Resolver now get the actual date and other info to allow more customization options.
Made it more Responsive you can now have the Schedjuler centered in the center of the screen. Space that was usally filled the Resouce Collumn. Old behavior is still the default.

Files that still have typecript issues: - I hope to get these fixed.

EventItem (has the most issues but I think is just because of the DnD)
WrapperFun.tsx (minor)
utility.ts (minor)

Updating items & DND is not tested and may have issues related to the change from date string to Dayjs. If these issues can be identified I can help fix them but I don't have a lot of time.

Might be better to make a new branch to put this on if you think these changes are usefull.

socket-security[bot] commented 2 months ago

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@babel/preset-typescript@7.24.7	Transitive: environment	`+43`	8.26 MB	nicolo-ribaudo
npm/@types/react-dom@18.2.23	None	`0`	34.9 kB	types
npm/@types/react@18.2.74	None	`+2`	1.68 MB	types

View full report↗︎

whoafridi commented 2 months ago

any plan to change the class components to functional one ? @pmm26

pmm26 commented 2 months ago

any plan to change the class components to functional one ? @pmm26

Not really while it would be nice to have them all on Functional Components. Class components still work and do the job.

Time spent vs Benefits is just not worth it at the moment for me, converting ComponentShouldUpdate ... is not that straight forward.

ansulagrawal commented 1 month ago

@pmm26 I will be creating a beta version of this release. Please let me know shall I do it or not?

codeclimate[bot] commented 1 month ago

Code Climate has analyzed commit b2ad54c8 and detected 138 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	62
Duplication	65
Clarity	1
Bug Risk	9
Style	1

Note: there are 4 critical issues.

View more on Code Climate.