search

react-theming / addon-development-kit

Addon Development Kit for Storybook
MIT License
33 stars 13 forks source link

🐞 Peer Dependencies do not support Storybook 6 and React 17 #8

Open siiiiilvio opened 3 years ago

siiiiilvio commented 3 years ago

I've been using your package with Storybook 6 and React 17 with no issues. However NPM 7 will not allow installation without passing the --force or --legacy-peer-depsflag because of these missing Peer Dependencies.

CWSites commented 2 years ago

Over 6 months, still not addressed.

warning "@react-theming/storybook-addon > @storybook/addon-devkit@1.4.1" has incorrect peer dependency "@storybook/addons@^5.0.0".
warning "@react-theming/storybook-addon > @storybook/addon-devkit@1.4.1" has incorrect peer dependency "@storybook/react@^5.0.0".
warning "@react-theming/storybook-addon > @storybook/addon-devkit@1.4.1" has incorrect peer dependency "react@^16.0.0".
warning "@react-theming/storybook-addon > @storybook/addon-devkit@1.4.1" has incorrect peer dependency "react-dom@^16.0.0".

In addition, @reach/react@0.2.1 needs to be upgraded to 0.16.0 which will handle the following warnings.

warning "@react-theming/storybook-addon > @storybook/addon-devkit > @reach/rect@0.2.1" has incorrect peer dependency "react@^16.8.0".
warning "@react-theming/storybook-addon > @storybook/addon-devkit > @reach/rect@0.2.1" has incorrect peer dependency "react-dom@^16.8.0".

Also here, a version of @reach/rect isn't specified so it's being loaded twice.

warning "@react-theming/storybook-addon > @storybook/addon-devkit > @reach/rect > @reach/component-component@0.1.3" has incorrect peer dependency "react@^16.4.0".
warning "@react-theming/storybook-addon > @storybook/addon-devkit > @reach/rect > @reach/component-component@0.1.3" has incorrect peer dependency "react-dom@^16.4.0".