Wrong behaviour with Storybook 6.X

react-theming / storybook-addon-material-ui

Addon for storybook wich wrap material-ui components into MuiThemeProvider. :page_with_curl: This helps and simplifies development of material-ui based components.

https://github.com/sm-react/storybook-addon-material-ui

MIT License

567 stars 131 forks source link

Wrong behaviour with Storybook 6.X #124

Open vitorcamachoo opened 3 years ago

vitorcamachoo commented 3 years ago

Hi,

After adding this addon to my storybook with version 6.X, I'm having some weird behaviours:

background of theme don't apply to component preview section
my addon panel is different from the displayed on README.md

usulpro commented 3 years ago

Hey @vitorcamachoo Yes background is out of the scope of this addon now as there is another addon to control backgrounds. In readme is initial version of addon panel for old version of Material UI. Now it changed and not all features can be supported.

vitorcamachoo commented 3 years ago

Hey @vitorcamachoo Yes background is out of the scope of this addon now as there is another addon to control backgrounds. In readme is initial version of addon panel for old version of Material UI. Now it changed and not all features can be supported.

Hi @UsulPro Any plans on supporting new version?

usulpro commented 3 years ago

@vitorcamachoo the plan is to switch the core of this addon to another one: https://github.com/react-theming/storybook-addon#using-with-material-ui and maintain it as an extension of react-theming/storybook-addon

You can already switch to this new one by yourself, see how to use it with Material-UI in readme.

vitorcamachoo commented 3 years ago

Thanks for the feedback. I will try your recomendation.