search

react-theming / storybook-addon-material-ui

Addon for storybook wich wrap material-ui components into MuiThemeProvider. :page_with_curl: This helps and simplifies development of material-ui based components.
https://github.com/sm-react/storybook-addon-material-ui
MIT License
567 stars 131 forks source link

Decorator Adding Extra Div #133

Open mcclayton opened 2 years ago

mcclayton commented 2 years ago

Does the decorator need to add an additional div as part of the decorator here:

https://github.com/react-theming/storybook-addon-material-ui/blob/b0ac1c444bd33212d693af182ac6fed1b069c3db/src/UI/MuiDecorator.js#L19

This is causing issues for stories that need to have 100% height.

mcclayton commented 2 years ago

Solved this by adding extra css for my storybook:

#root > div {
  height: 100%;
}

but would still be nice not to have the extra div if it can be avoided. Feel free to close if it can't be avoided.

usulpro commented 2 years ago

Thanks for spotting this. Let's remove it indeed!