react-theming / storybook-addon-material-ui

Addon for storybook wich wrap material-ui components into MuiThemeProvider. :page_with_curl: This helps and simplifies development of material-ui based components.
https://github.com/sm-react/storybook-addon-material-ui
MIT License
567 stars 131 forks source link

Prop warnings for themeName and themeNameArr #50

Closed hoschi closed 7 years ago

hoschi commented 7 years ago

I updated my dependcies:

-    "@kadira/storybook": "2.20.1",
+    "@kadira/storybook": "2.35.3",
-    "storybook-addon-material-ui": "0.7.2",
+    "storybook-addon-material-ui": "0.7.5",
-    "material-ui": "0.15.4",
+    "material-ui": "0.16.7",
-    "react": "15.3.1",
-    "react-dom": "15.3.1",
+    "react": "15.4.2",
+    "react-dom": "15.4.2",
-    "react-tap-event-plugin": "1.0.0",
+    "react-tap-event-plugin": "2.0.1",

Now I get warnings about props not passed to MuiTheme component: 2017-02-06-171730_1303x1384_scrot

I checked the component https://github.com/sm-react/storybook-addon-material-ui/blob/196e7c4a6bfd0c175666e00da2c7e4aa955b595d/src/containers/MuiTheme.js#L15 But it seems it doesn't do anything with them. Also my theme name and settings are visible in the panes added from your addon.

joshjconlin commented 7 years ago

removing both of those props from MuiTheme.js seems to fix the error

hoschi commented 7 years ago

sure, the question is: are these props really required or not. My quick code scan give me the opinion they are not used.

usulpro commented 7 years ago

Yes, we don't need them for now. Thank you!

hoschi commented 7 years ago

I'll test it when it is released.

usulpro commented 7 years ago

@hoschi, @joshjconlin! v0.7.6 is avalible on npm. No warnings in console should be

hoschi commented 7 years ago

works, thank you