search

react-theming / storybook-addon-material-ui

Addon for storybook wich wrap material-ui components into MuiThemeProvider. :page_with_curl: This helps and simplifies development of material-ui based components.
https://github.com/sm-react/storybook-addon-material-ui
MIT License
567 stars 131 forks source link

Crash when moving mouse over color palette in Material UI tab #86

Closed tlenex closed 5 years ago

tlenex commented 6 years ago

Image with error Occurs when moving mouse cursor over main color palette. After that, the Material UI tab becomes blank and error from the image bumps up in the console.

Version: 0.9.0-alpha.16 Storybook: 3.4.11

usulpro commented 6 years ago

Thanks for reporting @tlenex Hmm... I need to check. What version of Material-UI do you use?

tlenex commented 6 years ago

@UsulPro Material UI is ^3.2.0. Browser chrome latest. MacOS latest.

https://youtu.be/D8tBlSh45oo

usulpro commented 6 years ago

@tlenex I can't reproduce it with Storybook 3.4.11, but I hope it will be solved in the next release of addon alongside the other issues

tlenex commented 6 years ago

Thanks for heads up @UsulPro . I'll let you know if the problem still persists after next release. Perhaps this issue is only present with combination of some other storybook addons, I'll check.

tlenex commented 5 years ago

The problem was on my end.

I did not provide any palette color in my theme, adding it solved this issue. I think this could be handled by this plugin in the same way as in material-ui package, providing some defaults.

Closing for now.

usulpro commented 5 years ago

Thanks @tlenex for your reply and sorry for the inconvenience! I'll check about default themes, it should be considered as a bug if you can't use add on without own settings