Custom react scripts - Githubissues

react-toolbox / react-toolbox-example

Example using react-toolbox

143 stars 97 forks source link

Custom react scripts #35

Closed stereobooster closed 7 years ago

stereobooster commented 7 years ago

WIP. Everything works except I did it with Eject. Will modify custom-react-scripts so it would work without eject.

stereobooster commented 7 years ago

Idea behind this is to get integration out of the box

Open source tools tip: integrations are the killer feature. Reach out to people, help tools recognize each other, make them work in unison.
— Dan Abramov (@dan_abramov) October 5, 2016

javivelasco commented 7 years ago

Thanks for the PR! So this is about integrating react-create-app? I'm testing some stuff with react-toolbox@2.0.0-beta.0 and I think the easiest way to integrate is with a small preprocessing with css-next just for variables. The rest is unneeded. Also consider SASS support is going to be deprecated soon. Do you think this might be useful in a separate example repository?

stereobooster commented 7 years ago

I wait for @kitze to merge one PR, then I will lend final PR. It will allow to work 1.x react-toolbox with custom-react-scripts (not default default create-react-app, but not eject either). This PR will be much shorter than current version. I'm not sure how to handle css-next without eject.