search

react-toolbox / react-toolbox-themr

A tool to statically extract and generate custom themes for React Toolbox
MIT License
240 stars 24 forks source link

[Bug] Getting unknown browser dead query on build #69

Open luchillo17 opened 5 years ago

luchillo17 commented 5 years ago

Output of running the command: image

Short version: Probably outdated postcss-next with old BrowserList version that doesn't support dead query, actually npm says postcss-next has been deprecated in favor of postcss-preset-env.

I don't want to eject to be able to use react-toolbox, and i guess i'm not the only one.

Probably related issues: https://github.com/browserslist/browserslist/issues/323 https://github.com/browserslist/browserslist/issues/266 https://www.npmjs.com/package/postcss-cssnext

aaahrens commented 5 years ago

I am getting this too

mtermoul commented 5 years ago

me 3! any workaround?

I am getting this error when running:

npm run toolbox
BrowserslistError: Unknown browser query `dead`
luchillo17 commented 5 years ago

@mtermoul & @aaahrens Although React Toolbox itself is in active development, this one is abandoned since Apr 11 2017, there's 11 PR's pending to merge, i would consider this repo dead, since i don't want to eject my CRA app, i've moved to MaterialUI, i'm grateful i met this issue at the start of the app dev cycle.

mtermoul commented 5 years ago

@luchillo17 Thanks for pointing this fact, because I was getting frustrated about what do I need to do in order to have react-toolbox to work with CRA. Anyway this is the third UI framework that I tried with react so far and have to drop it because of issues like this or the lack of components. Material UI is #1 but comments are saying that it's necessarily complicated to customize your styles and change some colors for instance.

Honestly I tried Vue and Vuetify and by far it's much simpler and super productive.

Anyway, let me give Material UI another try and see if I can change my mind.

Thanks.

luchillo17 commented 5 years ago

@mtermoul Indeed Material UI is complex, but the complexity would end up being very close with React Toolbox (or very close for my case) but i was able to use that complexity, now my app has multi theme support, that can be changed at runtime.

The complexity is about knowing how to make the changes, once you know it's easy, basically the learning curve is steep as hell, but small.