search

react-ui-kit / expo-ui-kit

expo-ui-kit - a components based React-Native UI Kit
http://expo-ui-kit.com
MIT License
95 stars 25 forks source link

Default font color and allow <Block marginVertical> (marginHorizontal, margin Top...). #25

Closed jaysalvat closed 4 years ago

jaysalvat commented 4 years ago

1/ Only <Block margin> and <Block padding> worked.

Now, all the margin and padding properties work.

 <Block marginVertical>
 <Block marginHorizontal>
 <Block marginTop>
 <Block marginBottom>
 <Block marginLeft>
 <Block marginRight>

2/ The default font color can be set in the theme.

3/ Add the noflex property to avoid settings value to 0 and keep the component value free.

hetmann commented 4 years ago

@jaysalvat thank you for the PR and sorry that I didn't merge the changes from #dev branch so you have the up-to-date version of expo-ui-kit. Would it be ok if now I will merge the dev into master and you could update your PR?

jaysalvat commented 4 years ago

No problem. Please explain what you expect from me. I'm not sure to understand :)

hetmann commented 4 years ago

@jaysalvat you cloned the project from master branch but I had a lot of changes/updates on dev branch. The idea flow would have been to clone the dev branch and work on that.

That was my mistake and I was able to merge your PR to dev & master.

Right now master has all the change from the dev branch.