Block - new options - Githubissues

react-ui-kit / expo-ui-kit

expo-ui-kit - a components based React-Native UI Kit

http://expo-ui-kit.com

MIT License

95 stars 25 forks source link

Block - new options #32

Closed hetmann closed 4 years ago

hetmann commented 4 years ago

[x] Add new prop named scroll to render ScrollView component
[x] when row option is selected, flex value should be 0 by default
[x] add new props named width for View width style and height for View height style

talesdsp commented 4 years ago

Hey @hetmann. Just added these new features on the last PR #41 but I'm now thinking that the Block component just accepts a huge amount of props. It can be styling, event handlers, and now that list from ScrollView. For someone using this lib can be hard to remember everything that could be passed. Maybe it is time to start adding typescript?

hetmann commented 4 years ago

Hey @hetmann. Just added these new features on the last PR #41 but I'm now thinking that the Block component just accepts a huge amount of props. It can be styling, event handlers, and now that list from ScrollView. For someone using this lib can be hard to remember everything that could be passed. Maybe it is time to start adding typescript?

You are right. I had this in my backlog and right now I created the issue #42 . I was thinking that a type definition for each component would work for now.