search

react-ui-kit / expo-ui-kit

expo-ui-kit - a components based React-Native UI Kit
http://expo-ui-kit.com
MIT License
94 stars 25 forks source link

fix right on Block #75

Closed Charpell closed 4 years ago

Charpell commented 4 years ago

In the current behaviour, the right props on the Block component does not behave as expected

hetmann commented 4 years ago

@Charpell thanks ... the right option has the correct behaviour for flex content alignment on the main axis.

Take a look at this article https://css-tricks.com/snippets/css/a-guide-to-flexbox/ Visually justify-content is a more natural approach compared with align-items

We need to add a new option named align and have the options: "left" & "right"

If you don't mind I will close your PR, is it ok?

Charpell commented 4 years ago

Great @hetmann , but why does right and bottom have the same property justifyContent: "flex-end"

hetmann commented 4 years ago

Great @hetmann , but why does right and bottom have the same property justifyContent: "flex-end"

they are similar so it easier to use them when you can a row or column.

Is how the semantic is formed: row element position to right vs column element position to bottom

Charpell commented 4 years ago

Understood, you can close the PR

hetmann commented 4 years ago

Understood, you can close the PR

Thank you very much for your support. Keep on the good work.