search

react-ui-org / react-ui

React UI is a themeable and performant UI library for React apps.
https://react-ui.io
MIT License
21 stars 7 forks source link

Fix rendering glitch of `Popover` arrow on low-dpi displays #559

Closed atmelmicro closed 4 days ago

atmelmicro commented 3 weeks ago

Because of rendering quirks sometimes a line can appear between the popover and arrow

Snímek obrazovky 2024-08-23 v 9 08 11

(more visible on low dpi displays)

This pr fixes that by moving the arrow 1px down

Snímek obrazovky 2024-08-23 v 9 44 18
adamkudrna commented 3 weeks ago

The PR name could be like "Fix rendering glitch of Popover arrow on low-dpi displays". There is no intentional line so it cannot be removed… 🙂

atmelmicro commented 5 days ago
Snímek obrazovky 2024-09-12 v 14 58 05

Hey, the build failing because of the bundle being too big. Is it safe to merge?

mbohal commented 5 days ago

@atmelmicro

Please do increase the allowed size: image

Here, as well as in our other codebases, we do not have a strict size increase process. We use the limit as a general guideline to prevent the size from exploding beyond reason as a result of bad development decision or a an error.

So if you, as the change author, consider the size increase justified, then feel free to increase the limit. The limit change will be reviewed during the CR same as any other change.

The size increase in this PR is minimal and is fine by me.