react-webpack-generators / generator-react-webpack

Yeoman generator for ReactJS and Webpack
http://newtriks.com/2013/12/31/automating-react-with-yeoman-and-grunt/
MIT License
2.88k stars 355 forks source link

Running app generator does not create project scaffold #271

Closed loosenRogers closed 8 years ago

loosenRogers commented 8 years ago

when iI follow the introduction to generate my project, here comes the error. my command:"yo react-webpack galleyReact",i want to use react-webpack to generate a project named "galleryReact",then ? Please choose your application name (galleryReact)

events.js:141 throw er; // Unhandled 'error' event ^

TypeError: this.env.adapter.prompt(...).then is not a function at Base.prompt (C:\Users\Administrator\AppData\Roaming\npm\node_modules\generator-react-webpack\node_modules\yeoman-generator\lib\base.js:240:45) at module.exports.generator.Base.extend.prompting (C:\Users\Administrator\AppData\Roaming\npm\node_modules\generator-react-webpack\generators\app\index.js:40:10) at Object. (C:\Users\Administrator\AppData\Roaming\npm\node_modules\generator-react-webpack\node_modules\yeoman-generator\lib\base.js:439:23) at C:\Users\Administrator\AppData\Roaming\npm\node_modules\generator-react-webpack\node_modules\yeoman-generator\node_modules\run-async\index.js:26:25 at C:\Users\Administrator\AppData\Roaming\npm\node_modules\generator-react-webpack\node_modules\yeoman-generator\node_modules\run-async\index.js:25:19 at C:\Users\Administrator\AppData\Roaming\npm\node_modules\generator-react-webpack\node_modules\yeoman-generator\lib\base.js:440:9 at processImmediate as _immediateCallback

i have no idea of solving this problem,hoping you can give some help,thanks!

sthzg commented 8 years ago

@loosenRogers can you post which version of the yo cli you are using? yo --version on the command line should output the version number (do the steps in this SO question solve the issue?)

loosenRogers commented 8 years ago

the version of the yo cli is 1.5.1

loosenRogers commented 8 years ago

i update my yo version to 1.8.4 ,then i try generate the project again. This is the result: Out of the box I include Webpack and some default React components.

? Please choose your application name (galleryReact) galleryReact ? Please choose your application name galleryReact ? Which style language do you want to use? (Use arrow keys) ? Which style language do you want to use? sass ? Enable postcss? (y/N) y ? Enable postcss? Yes But i found there was no project generated.

marcuspeterson commented 8 years ago

I was having this exact same error, but it appears installing directly from using npm seemed to resolve the issue for me. npm uninstall -g generator-react-webpack npm install -g https://github.com/react-webpack-generators/generator-react-webpack.git

sthzg commented 8 years ago

@loosenRogers @FamiliarPie hi guys, thanks for reporting. I can reproduce the problem on my local machine. There have been quite a few changes in the past days, both in terms of code and infrastructure (e.g. moving the repository url of this generator), so maybe some wires got crossed along the way. Sorry that you ran into these problems, we'll look into it right away.

sthzg commented 8 years ago

Okay, the reason is due to the updated dependency to yeoman-generator 0.24, which moved over to a newer version of inquirer.js that started moving to promises (and thus deprecates removed the var done = this.async() api). Fix is coming in the next minutes.

sthzg commented 8 years ago

Thanks again for reporting, this fix will be available through npm with the next releasee of the generator. I am leaving this ticket open as a reminder until the package is published.

weblogixx commented 8 years ago

Sorry, this was my fault :(. It seems I did not run tests before publishing the actual v3 stable. @sthzg: Sorry you had to step in, great work as always! Thank you! You may publish any time, npm permissions are set up accordingly.

sthzg commented 8 years ago

@weblogixx no worries, I fixed exactly the same issue a short while ago on another gist, so I already had an idea about where it is coming from.

New patch release v3.3.4 is published on npm.

acwonders commented 8 years ago

I had the exactly same issue yesterday on v3.3.3. Just tried with v3.3.4 and the issue is gone. Thanks!

sthzg commented 8 years ago

@acwonders 🙇 thanks for testing the update and taking your time to confirm the fix. much appreciated.