search

react-webpack-generators / generator-react-webpack

Yeoman generator for ReactJS and Webpack
http://newtriks.com/2013/12/31/automating-react-with-yeoman-and-grunt/
MIT License
2.88k stars 355 forks source link

V4 -- Update for template v2.0.1-5 #306

Closed stylesuxx closed 7 years ago

stylesuxx commented 7 years ago

Primarly needed to update the way, the postcss related stuff is attached since it is attached to the webpack config, which has changed.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.04%) to 96.19% when pulling e4ef5bd8e55be04656763ccb3f4a301e106e1165 on stylesuxx:master into b581e5bd021da0ca2871a27d66bbcd9279887c63 on react-webpack-generators:master.

sthzg commented 7 years ago

@stylesuxx changes are looking good. does this fix the PostCSS part completely (from the template side)? Then I'd merge and publish the next pre-release. Otherwise I'd merge and wait a little before publishing.

stylesuxx commented 7 years ago

I have not tested the postcss part yet, but I can do that in the evening and report back - if I did not completely mess up the webpack config it should still be working - at least the tests pass regarding the attachment of the postcss functionality. I remember you mentioned that something was not working properly - can you link me to an issue?

sthzg commented 7 years ago

That is a good question. AFAIK in the V4 generator the PostCSS part was reported to be buggy. I couldn't find a Github issue, but this comment serves as an indicator that there were problems. Maybe @weblogixx still has a bit of context on that. Otherwise I will also test a setup and see what it does/does not do.

I will merge this to 2.x now so that it can be tested against the template w/ the necessary modifications in this PR.

sthzg commented 7 years ago

FYI: I tested an installation w/ PostCSS enabled and filed an error on this issue #307.