V4 -- Cssmodules decorator in component

react-webpack-generators / generator-react-webpack

Yeoman generator for ReactJS and Webpack

http://newtriks.com/2013/12/31/automating-react-with-yeoman-and-grunt/

MIT License

2.88k stars 355 forks source link

V4 -- Cssmodules decorator in component #325

Closed stylesuxx closed 7 years ago

stylesuxx commented 7 years ago

From here the template seems to be using decorators in the v4.0.1-1 branch => https://github.com/react-webpack-generators/generator-react-webpack/blob/v4.0.1-1/generators/component/templates/4/components/Base.js

I think the master is more up to date regarding those templates, or am I missing something?

sthzg commented 7 years ago

@stylesuxx I refactored that when I was rebuilding the base templates for the different components. Main reasons were to get rid of conditionals in the ejs templates and decorators in general as they are still only a draft and haven't made their way into the standard yet (has that changed in the meantime?).

stylesuxx commented 7 years ago

Yes, sorry. I meant to close that down yesterday. It was late and I managed to confuse myself. My gen was using the latest v4 tag, but the base for the next v4 is master, so I switched that and everything is OK now.

sthzg commented 7 years ago

:smile: glad to hear.