search

react-webpack-generators / react-webpack-template

Simple react webpack template
MIT License
82 stars 43 forks source link

Fix override order for base.js and dev.js / dist.js #10

Closed mjul closed 9 years ago

mjul commented 9 years ago

In lodash _.merge the last entry wins, so I have moved the baseConfig to the front of the merge, so that the locally defined settings in dev.js and dist.js will have priority.

catalinmiron commented 9 years ago

+1

weblogixx commented 9 years ago

@mjul: Technically speaking you are right. But try it out, you will see that it does not work. This is because it will alter the first entry to include the merge, which means the baseConfig will be altered when the files are loaded. This results in dev enviroment beeing overridden. Therefore, I opted to override a plain object, which does not do any harm. Sorry, have to roll back this