react-webpack-generators / react-webpack-template

Simple react webpack template
MIT License
82 stars 43 forks source link

feat: add sass and scss file resolve #14

Closed boiawang closed 8 years ago

boiawang commented 8 years ago

import react-toolbox error. Because it introduces scss files.

Module not found: Error: Cannot resolve 'file' or 'directory' ./style in /Users/react/react-example/node_modules/react-toolbox/lib/button
weblogixx commented 8 years ago

Hi @boiawang,

first, let me thank you for your contribution. As you may know we already have support for sass and scss built in. You are also right that files by third party libs wont be resolved by the aliases. Your pr would fix that for your case, but I currently do not think that it is necessary for all generated projects.

Any other opinions on this?

weblogixx commented 8 years ago

Nothing new in a month, closing this. @boiawang: Feel free to open a issue if there are problems. We have upgraded sass to a (much) newer version in the latest release. Maybe this will fix your issue.