search

react-webpack-generators / react-webpack-template

Simple react webpack template
MIT License
82 stars 44 forks source link

Move core-js, lodash and react-addons-test-utils to devDependencies #17

Closed harunhasdal closed 8 years ago

harunhasdal commented 8 years ago

This moves core-js, lodash and react-addons-test-utils dependencies in package.json to devDependencies.

This is to keep the dependencies to the front-end code dependencies and make sure anything that is used just for build/test purposes is specified under devDependencies.

weblogixx commented 8 years ago

Hi @harunhasdal,

thank you for your contribution. You are right that lodash and the testutils should not be in the regular dependency list. core-js on the other hand should, as we use it to override default settings in src/config/*.js (see src/config/dev.js for an example).

Would you provide an updated pr without core-js in devDependencies? Will happily merge it. Thanks :)

harunhasdal commented 8 years ago

@weblogixx I thought it would still be classified as a dev dependency as the configs are processed in build time. However I am happy to move it back to the dependencies, if that makes more sense to you that way.

Will update the PR soon.

weblogixx commented 8 years ago

Nice, will merge it into the next release! Thank you