search

react-webpack-generators / react-webpack-template

Simple react webpack template
MIT License
82 stars 43 forks source link

V2 -- Updated Dependencies, Webpack, Hot reloader #72

Closed stylesuxx closed 7 years ago

stylesuxx commented 7 years ago

I have made the needed changes for the v4 gen to work with this PR too, so as soon as this gets pulled, i will open a PR in the other repo.

sthzg commented 7 years ago

Hi @weblogixx @stylesuxx,

could you coordinate these updates between you two? According to the last comment https://github.com/react-webpack-generators/generator-react-webpack/issues/302#issuecomment-261860519 @weblogixx is planning to do the updates. But that might have overlapped with this PR (on a side-note: I need to check the Github email settings, as I don't get emails for new PRs).

@stylesuxx thanks for the PR. I haven't had time to check in detail, but I haven't seen a few of the integrations I had to do to make it work (changes to babelrc, wrapping Main in the <AppContainer /> component, manually triggering the module.hot.accept() API, adding react-hot-loader/patch as an entry point in Dev.js). The last time I've set it up was about three weeks ago, do you know if this is obsolete by now? (I still see it in their next-docs branch https://github.com/gaearon/react-hot-loader/tree/next-docs/docs, but code might progress quicker than docs 😄 ).

As said above, as @weblogixx mentioned to update the projects in the linked comment I think it would be the best if you two coordinated it between each other so that there is no double-work on that.

stylesuxx commented 7 years ago

OK, I have not seen this comment yet. But it works for me - If @weblogixx has something tested, then I am happy.

Point is, my redux gen is using the V4 of the react gen which uses the latest V2.x template so problems down here are bubbling up on my side and I thought I'll just make the first step to get things rolling ;-)

@sthzg pretty sure I did test hot reloading, but I guess I should double check because I did not make this changes.

Let me know how I can help.

weblogixx commented 7 years ago

Hi @stylesuxx,

unfortunately, I do not have the time for an emergency fix today :(. @sthzg: Could you please have a look at it? From the first (5 minute) view, it looks good and may get published.

Thanks and sorry :(