Doesn't work with Firebase

[marcelmika]

First, thanks for a great lib! We almost made it work until we had to include Firebase as a dependency.

cd packages/apps/app-one
yarn add firebase@6.2.0

As you can see here: https://www.npmjs.com/package/firebase#npm-bundler-browserify-webpack-etc you simply import a firebase package:

// In your code, you can access Firebase using:
var firebase = require('firebase');
var app = firebase.initializeApp({ ... });

// If you are using ES6 imports or TypeScript:
import * as firebase from 'firebase';
var app = firebase.initializeApp({ ... });

Unfortunately, when we do it we get the following error:

TypeError: util.inherits is not a function

Also, the console prints a couple of warnings:

We are not having this issue when we use a standard CRA.

[F1LT3R]

Do you have a repo with this setup that I can look at?

[marcelmika]

Sure, check the feature/firebase branch: https://github.com/marcelmika/react-workspaces-playground/tree/feature/firebase

Here's the diff: https://github.com/react-workspaces/react-workspaces-playground/compare/master...marcelmika:feature/firebase

[F1LT3R]

It seems like a Webpack issue. If you use the same version of CRA w/o react-workspaces-playground, does firebase still have the same issue? (Ie: possible incompatible versions of Create React App and Firebase)

[WayneEllery]

I’m having the same issue. Firebase works with CRA w/o react-workspaces-playground

[F1LT3R]

@marcelmika - I get a lot of errors when I try to run yarn on your repo. I don't get these with the normal React Workspaces Playground repo that is currently on master.

Do you have a repo where this is working with CRA-only?

When I try to run your code from yarn start in app-one, I see your util error, but I also see a firebase dependency is missing.

[F1LT3R]

Things I tried that did not work:

1. Installing latest Firebase
2. Removing node_modules and yarn.lock then re-installing

[F1LT3R]

I'm able to get a different set of errors when using hoisting for firebase in the root workspace package.json. I'm thinking there's a conflict that we can get around by hoisting correctly. Updating the to latest CRA may help.

[F1LT3R]

I will try to check Firebase again soon. It may "just work" after updating to latest React v3.3.0. That update work is being done here: https://github.com/react-workspaces/react-workspaces-playground/pull/21