Closed marcelmika closed 4 years ago
Do you have a repo with this setup that I can look at?
Sure, check the feature/firebase
branch:
https://github.com/marcelmika/react-workspaces-playground/tree/feature/firebase
Here's the diff: https://github.com/react-workspaces/react-workspaces-playground/compare/master...marcelmika:feature/firebase
It seems like a Webpack issue. If you use the same version of CRA w/o react-workspaces-playground, does firebase still have the same issue? (Ie: possible incompatible versions of Create React App and Firebase)
I’m having the same issue. Firebase works with CRA w/o react-workspaces-playground
@marcelmika - I get a lot of errors when I try to run yarn
on your repo. I don't get these with the normal React Workspaces Playground repo that is currently on master.
Do you have a repo where this is working with CRA-only?
When I try to run your code from yarn start
in app-one
, I see your util error, but I also see a firebase dependency is missing.
Things I tried that did not work:
node_modules
and yarn.lock
then re-installingI'm able to get a different set of errors when using hoisting for firebase in the root workspace package.json
. I'm thinking there's a conflict that we can get around by hoisting correctly. Updating the to latest CRA may help.
I will try to check Firebase again soon. It may "just work" after updating to latest React v3.3.0. That update work is being done here: https://github.com/react-workspaces/react-workspaces-playground/pull/21
First, thanks for a great lib! We almost made it work until we had to include Firebase as a dependency.
As you can see here: https://www.npmjs.com/package/firebase#npm-bundler-browserify-webpack-etc you simply import a firebase package:
Unfortunately, when we do it we get the following error:
Also, the console prints a couple of warnings:
We are not having this issue when we use a standard CRA.