Open abrkn opened 4 years ago
Have you tried removing them? What happens?
I see an index.tsx
in the same dir as package.json
.
It may be in the wrong place. As far as collecting the babel-paths is concerned, my guess is that it should make no difference. Because the code is located in src/
babel should still be able to load the code in the child path.
It's an oversight for sure. The same issue is found in the JavaScript components dir: https://github.com/react-workspaces/react-workspaces-playground/tree/master/packages/components
It has been many months since I used React or React-Workspaces, so I'm a little rusty, but I think those index files should be moved into the src/
directory - and the index code should be:
export { default as CompOne } from './CompOne';
export { default as CompTwo } from './CompTwo';
Do you want to submit a PR?
In packages/components-typescript/package.json the fields
main
andmain:src
: refer to files that do not exist:The
index.tsx
file is located in packages/components-typescript/index.tsxAre these two fields redundant?