search

react-workspaces / react-workspaces-playground

⚛️ 🐈 Zero Config Create-React-App Monorepos with Yarn Workspaces, Lerna and React Storybook.
https://react-workspaces.github.io/react-workspaces-playground/
763 stars 128 forks source link

Unknow problem with "path" after successfully compiling #50

Open ppalmeida opened 4 years ago

ppalmeida commented 4 years ago

First of all: thank you so much for this package. It's really awesome.

I have a problem after creating a new package package/ui - that is not a CRA app, in fact, it is just a copy of the 'typescript component' package.

I made a repo that reproduces the problem and in the README file there is the error output. All tests pass and the screen.debug() of React testing-library is ok and shows all the HTML of components. I've tried in all browsers even in Safari, which has no dev extension at all.

Could you please take a look? If tests are all green and rendering the components, why in the browser it's throwing errors? I could not find what's happening.

EDIT:

Description Version
OSX 10.14.6
Yarn 1.19.1
Lerna 3.15.0
Node v10.15.3
ppalmeida commented 4 years ago

Ok. This is not a problem with this repo itself. It's a bug in CRA - as we can see here and here. As far as I can see, the problem was solved in react-scripts: 3.4.1.

There is indeed a PR to fix the upgrade react-scripts waiting for over a month. Is there someone actually taking care of this repo? Sorry for asking, I do not intend to be rude, but we deff should take a look at it. I can contribute or help in anything, just drop me a message here or on my Twitter - [at]ppalmeida.