search

react95-io / React95

🌈🕹 Windows 95 style UI component library for React
https://react95.io
MIT License
6.7k stars 187 forks source link

Storybook build output folder #10

Closed niedzielnyaniol closed 5 years ago

niedzielnyaniol commented 5 years ago

https://github.com/arturbien/React95/blob/eb6b8f98bb36da6b3733c5c128dac8f9112cc297/package.json#L27

Are you sure that you want to build your storybook into docs folder and keep it in git repo?

arturbien commented 5 years ago

@niedzielnyaniol Any suggestions? 😊 is there something wrong with the current approach? thanks for getting involved

niedzielnyaniol commented 5 years ago

Storybook recommendation

This will build the storybook configured in the Storybook directory into a static web app and place it inside the .out directory. Now you can deploy the content in the .out directory wherever you want.

For me docs/ should contains *.md files in most cases. What about building storybook - i would set out dir to .out/ and keep it in .gitignore then add build:storybook to release command in your package.json scripts that update storybook after publishing new release

panmona commented 5 years ago

You can of course change it but I don't see what this project gains from it right now.

arturbien commented 5 years ago

@niedzielnyaniol for now I think it's all good. Right now only documentation we have is the storybook so let it be 😊