react95-io / React95

🌈🕹 Windows 95 style UI component library for React
https://react95.io
MIT License
6.65k stars 185 forks source link

[V4] Add support for MenuList checkbox and radio #367

Open arturbien opened 1 year ago

arturbien commented 1 year ago

We've removed "menu" variant of the Radio and Checkbox component, because this type of thing should be a part of the <MenuList />.

Page 116 https://www.ics.uci.edu/~kobsa/courses/ICS104/course-notes/Microsoft_WindowsGuidelines.pdf

Screenshot 2022-11-10 at 23 45 58

We should think it through really well considering that soon we'll also have to add support for <MenuListItem /> icons. Screenshot below shows how Material UI handles it. It looks like MenuItem checkbox is just an item with checkmark icon in it, and all stuff around accessibility/state should be handled by devs implementing the menu list checkbox / radio.

Screenshot 2022-11-10 at 23 37 42