react95-io / React95

🌈🕹 Windows 95 style UI component library for React
https://react95.io
MIT License
6.65k stars 185 forks source link

"Active" button not getting focused state (dashed inner border) #383

Closed arturbien closed 1 year ago

arturbien commented 1 year ago

"Active" button not getting focused state (dashed inner border):

Screenshot 2023-04-08 at 14 59 09
afzalzbr commented 1 year ago

Please assign this issue to me for working on it. Thanks

arturbien commented 1 year ago

@afzalzbr awesome. Thank you and good luck!

afzalzbr commented 1 year ago

The focusOutline was not including any case for active === true.

I've made changes in the file: src\Button\Button.tsx: image

Following is the working example of the fix for the 'Active' button, followed by a picture showing no other buttons' styles are being compromised: image

image

I hope this helps!

@arturbien, Lemme know if anything else needs to be done.

arturbien commented 1 year ago

@afzalzbr I'll review this PR tomorrow!