react95-io / React95

🌈🕹 Windows 95 style UI component library for React
https://react95.io
MIT License
6.65k stars 185 forks source link

bug fix: "Active" button not getting focused state #384

Closed afzalzbr closed 1 year ago

afzalzbr commented 1 year ago

The focusOutline was not including any case for active === true.

I've made changes in the file: src\Button\Button.tsx: image

Following is the working example of the fix for the 'Active' button, followed by a picture showing no other buttons' styles are being compromised: image

image

I hope this helps!

Fixes #383

arturbien commented 1 year ago

@afzalzbr there are some linting issues in CI

afzalzbr commented 1 year ago

@arturbien okay I'll check.

afzalzbr commented 1 year ago

@arturbien fixed the linting issue, please review and approve.

afzalzbr commented 1 year ago

@arturbien yup, you are right. I removed it and it's working fine now.

arturbien commented 1 year ago

@afzalzbr great! Now before I merge please squash all the commits into single commit with message:

fix(Button): active button focus outline

afzalzbr commented 1 year ago

@arturbien done

arturbien commented 1 year ago

@afzalzbr your commit was merged to master. Thank you for the contribution <3