implemented support for custom components to be used in place of the …

reactabular / searchtabular

Search utilities (MIT)

MIT License

5 stars 17 forks source link

implemented support for custom components to be used in place of the … #1

Closed tpizza closed 7 years ago

tpizza commented 7 years ago

@bebraw Here's my implementation for passing a custom component through to Field in searchtabular.

codecov-io commented 7 years ago

Current coverage is 91.20% (diff: 95.23%)

Merging #1 into master will increase coverage by 3.25%

@@             master         #1   diff @@
==========================================
  Files            11         11          
  Lines           166        182    +16   
  Methods          25         28     +3   
  Messages          0          0          
  Branches         63         71     +8   
==========================================
+ Hits            146        166    +20   
+ Misses           20         16     -4   
  Partials          0          0

Powered by Codecov. Last update f1d32d8...e259ed9

git-toni commented 7 years ago

@tpizza thanks for the PR, I'll wait for @bebraw 's opinion before merging. I've been a bit busy with other things and I'm not sure how much he's using searchtabular in general for reactabular` :)

tpizza commented 7 years ago

@bebraw IntelliJ ignore has been removed.

tpizza commented 7 years ago

Ahhh, I just saw the request for the readme update. Will make that revision now.

bebraw commented 7 years ago

Published as 1.3.0. Thanks.

git-toni commented 7 years ago

@bebraw Oh, now I see mixed selectabular(which I collaborated a bit with) with searchtabular, you must have thought I'm crazy : )

bebraw commented 7 years ago

@git-toni No probs.