reactabular / searchtabular

Search utilities (MIT)
MIT License
5 stars 17 forks source link

fix defaultTransform did not handle arrays #10

Closed dready closed 7 years ago

dready commented 7 years ago

this was the last problem in dealing with array values in the search as described in #3.

Highlighting is still another problem.

bebraw commented 7 years ago

Cool. Looks like the linter is choking, though.

dready commented 7 years ago

sure, will start writing tests right away.

i will look into the highlighting, i have a workaround in place working so it is not a big deal.

codecov-io commented 7 years ago

Codecov Report

Merging #10 into master will decrease coverage by -0.97%. The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #10      +/-   ##
=========================================
- Coverage   90.27%   89.3%   -0.97%     
=========================================
  Files          11      11              
  Lines         185     187       +2     
  Branches       71      73       +2     
=========================================
  Hits          167     167              
- Misses         18      20       +2
Impacted Files Coverage Δ
src/_column-matches.js 100% <100%> (ø) :white_check_mark:
src/strategies.js 84.78% <ø> (-4.35%) :x:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a314b7...14f8126. Read the comment docs.

bebraw commented 7 years ago

Thanks. Included in 1.4.0. The highlight bits can go in a separate PR. 👍

dready commented 7 years ago

thanx, it's not as easy as i thought.. i already tried several possible ways and every time it got messy and did not solve the problem.. this is a tough nut