search

reactabular / searchtabular

Search utilities (MIT)
MIT License
5 stars 17 forks source link

handle arrays correctly within the highlight formatters #14

Closed dready closed 7 years ago

dready commented 7 years ago

fix highlightings for arrays

codecov-io commented 7 years ago

Codecov Report

Merging #14 into master will increase coverage by 0.22%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage    89.3%   89.52%   +0.22%     
==========================================
  Files          11       11              
  Lines         187      191       +4     
  Branches       74       77       +3     
==========================================
+ Hits          167      171       +4     
  Misses         19       19              
  Partials        1        1
Impacted Files Coverage Δ
src/matches.js 100% <100%> (ø) :arrow_up:
src/formatters/highlight-value.js 100% <100%> (ø) :arrow_up:
src/_column-matches.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2fe1492...5a6cd0c. Read the comment docs.

dready commented 7 years ago

I haven't touched any of the code for which the checks are failing.

bebraw commented 7 years ago

Thanks a lot. Included in 1.6.0. The BitHound failures are something for me to fix (old deps).