reactdeveloperske / reactdevske-website

This is the community showcase website for The React js Developer Community Website
https://reactdevske.org
MIT License
55 stars 77 forks source link

[feature] create contact us section (Form UI) #102

Closed devKiratu closed 1 year ago

devKiratu commented 1 year ago

Fixes Issue

Closes #82

Changes proposed

The following requirements are fulfilled by this PR:

Check List (Check all the applicable boxes)

Screenshots

Desktop version Screenshot 2022-10-24 at 13-52-42 Reactjs Developer Community in Kenya

Mobile version

Screenshot 2022-10-24 at 14-37-27 reactdevske-contactus-mobile png (PNG Image 492 × 833 pixels) — Scaled (85%)

Note to reviewers

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
reactdevske-website ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 6:47PM (UTC)
antosan commented 1 year ago
  • In the mobile version of the form, the Name field does not have an icon like the other input fields. Is this the design or was it an omission?

This is the design.

  • In my view, there are quite significant differences between the mobile and the desktop version of the form, such that creating a single component and modifying it with media queries alone did not produce clean code, and some features were difficult to implement. I therefore created two versions (mobile and desktop) and rendered them conditionally. I would like to hear your thoughts on this approach

You handled it really well. Thanks.

devKiratu commented 1 year ago
  • In the mobile version of the form, the Name field does not have an icon like the other input fields. Is this the design or was it an omission?

This is the design.

  • In my view, there are quite significant differences between the mobile and the desktop version of the form, such that creating a single component and modifying it with media queries alone did not produce clean code, and some features were difficult to implement. I therefore created two versions (mobile and desktop) and rendered them conditionally. I would like to hear your thoughts on this approach

You handled it really well. Thanks.

Thank you!