Closed devKiratu closed 1 year ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
reactdevske-website | ✅ Ready (Inspect) | Visit Preview | Oct 24, 2022 at 6:47PM (UTC) |
- In the mobile version of the form, the
Name
field does not have an icon like the other input fields. Is this the design or was it an omission?
This is the design.
- The button used is a dummy one and will be replaced once the reusable button (issue Implement the Button Component #85 ) is ready
✅
- In my view, there are quite significant differences between the mobile and the desktop version of the form, such that creating a single component and modifying it with media queries alone did not produce clean code, and some features were difficult to implement. I therefore created two versions (mobile and desktop) and rendered them conditionally. I would like to hear your thoughts on this approach
You handled it really well. Thanks.
- In the mobile version of the form, the
Name
field does not have an icon like the other input fields. Is this the design or was it an omission?This is the design.
- The button used is a dummy one and will be replaced once the reusable button (issue Implement the Button Component #85 ) is ready
✅
- In my view, there are quite significant differences between the mobile and the desktop version of the form, such that creating a single component and modifying it with media queries alone did not produce clean code, and some features were difficult to implement. I therefore created two versions (mobile and desktop) and rendered them conditionally. I would like to hear your thoughts on this approach
You handled it really well. Thanks.
Thank you!
Fixes Issue
Closes #82
Changes proposed
The following requirements are fulfilled by this PR:
ContactUs
in thecomponents
folder that implements the screenshots below.section
tag with anid
ofcontact-us
.index.page.tsx
Button
component.required
attribute.Check List (Check all the applicable boxes)
Screenshots
Desktop version
Mobile version
Note to reviewers
Name
field does not have an icon like the other input fields. Is this the design or was it an omission?