search

reactdeveloperske / reactdevske-website

This is the community showcase website for The React js Developer Community Website
https://reactdevske.org
MIT License
55 stars 77 forks source link

House keeping (05-04-2023) #131

Closed orama254 closed 1 year ago

orama254 commented 1 year ago

Changes proposed

Fixes the remaining parts of #118 plus also adds additional information to the contribution guidelines. Also added some updated workflow for end to end playwright tests

vercel[bot] commented 1 year ago

@orama254 is attempting to deploy a commit to a Personal Account owned by @reactdeveloperske on Vercel.

@reactdeveloperske first needs to authorize it.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reactdevske-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2023 8:05pm
orama254 commented 1 year ago

Another thing I have noticed is that we have the word "Events" appearing severally on the page and this will cause one of the tests to be ambiguous and fail. This test in home.spec.ts should be adjusted to be an exact match by adding exact: true:

test('should show Events section', async ({ page }) => {
  await expect(
    page.getByRole('heading', { name: 'Events', exact: true })
  ).toBeVisible();
});

@antosan Very nice, the tests are passing.

on the requested changes above, I'm getting an error with typescript that these are the expected parameters for that:

{ checked?: boolean | undefined; disabled?: boolean | undefined; expanded?: boolean | undefined; includeHidden?: boolean | undefined; level?: number | undefined; name?: string | RegExp | undefined; pressed?: boolean | undefined; selected?: boolean | undefined; }

exact: boolean seems to be missing