Twitter logo updated to X

reactiflux / reactiflux.com

Reactiflux Website

https://www.reactiflux.com/

MIT License

250 stars 53 forks source link

Twitter logo updated to X #283

Closed Atharv0003 closed 10 months ago

Atharv0003 commented 11 months ago

Twitter logo updated to X fixes: #282

what-the-diff[bot] commented 11 months ago

PR Summary

Modification of twitter.svg File The design details of the Twitter icon used in the project have been changed. Specific alterations include:
- Removal of set size attributes. This change allows the icon to be more flexible and dynamically adjust its size based on where and how it's used within the project.
- The color code of the icon has been slightly modified to better align with the overall color scheme of the project.
- Additional design elements have been incorporated into the icon to enhance its visual appeal and make it more aesthetically pleasing.

Atharv0003 commented 11 months ago

@vcarl please review and merge the request

Atharv0003 commented 11 months ago

@zachgibson please review and merge the request

vcarl commented 11 months ago

I'm not seeing what accessibility tree you mean. The site has rebranded, this logo is correct

nickserv commented 11 months ago

The accessibility tree is a supplemental tree of accessibility data for assistive technology, similar to how the DOM provides data for graphical renderers. Describing the X logo as the Twitter logo is clearly incorrect, but I can fix this and some other inconsistencies.

vcarl commented 11 months ago

You're saying we need to update the image alt tags? I agree, that's good to do.

nickserv commented 10 months ago

@Atharv0003 Sorry I accidentally closed and can't reopen this. I'll send a new pull and mention you if you want to review it.