search

reactioncommerce / docker-base

Apache License 2.0
4 stars 11 forks source link

add git to node-dev #27

Closed misha-erm closed 4 years ago

misha-erm commented 4 years ago

Git is not installed in node-dev image so it's not possible to use git repos as packages

misha-erm commented 4 years ago

Hello, Can we merge this, please? @aldeed @rosshadden

rosshadden commented 4 years ago

@MikeYermolayev If your needs are such that you need git in the image so you can use it with npm, I think your best course of action is to extend the image and add git to your own. A case for git could certainly be made based around it being generally helpful in a dev environment, but with your specific use case it just doesn't make sense to add to the image. You would run into the same problem with the node-prod image when you go to use it for production, and in that case the "generally helpful in a dev environment" argument loses its ground.

misha-erm commented 4 years ago

@rosshadden thanks for the reply. My first idea was to do it locally specifically for my use case but the reason why I created this PR is that the git is present in node-prod image https://github.com/reactioncommerce/docker-base/blob/trunk/images/node-prod/12.14.1-v2/Dockerfile#L4

And, as you can see v2 was created for prod but not for the dev environment. And as you can see the documentation claims that git repos should be OK image

Looks like there is some inconsistency Thanks

rosshadden commented 4 years ago

Well why didn't you say so? That's a great point, thanks!

misha-erm commented 4 years ago

sorry for the unclear description) thanks