search

reactioncommerce / docker-base

Apache License 2.0
4 stars 11 forks source link

Production image is missing Sharp binary / Phyton #6

Closed janus-reith closed 4 years ago

janus-reith commented 4 years ago

The sharp binaries don't get included in the production build for 3.0.

https://github.com/reactioncommerce/docker-base/blob/5127ac023c2ea988c3e3a5d70055006c1bb10b7a/images/node-dev/12-10-0-v2/Dockerfile#L4 includes an install step for python2 while https://github.com/reactioncommerce/docker-base/blob/5127ac023c2ea988c3e3a5d70055006c1bb10b7a/images/node-prod/12-10-0-v1/Dockerfile#L4 does not.

Python is required to build libvips.

janus-reith commented 4 years ago

Also, I had to add a npm rebuild step to my Reaction Dockerfile so the modules were actually build.