search

reactioncommerce / example-storefront

Example Storefront is Reaction Commerce’s headless ecommerce storefront - Next.js, GraphQL, React. Built using Apollo Client and the commerce-focused React UI components provided in the Storefront Component Library (reactioncommerce/reaction-component-library). It connects with Reaction backend with the GraphQL API.
https://www.mailchimp.com/developer/open-commerce
Apache License 2.0
608 stars 288 forks source link

chore: adding git hooks for commit-msg #753

Closed Akarshit closed 3 years ago

Akarshit commented 3 years ago

Resolves #752 Impact: minor Type: chore

Issue

No commit-msg hooks, so the commit message were a little out of consistency.

Solution

Adding commit-msg hooks using husky.

Breaking changes

None

Testing

  1. Pull the branch.
  2. Run npm i
  3. Make some edit.
  4. Try to commit, something weird like "this is a invalid commit". The hooks should fail.
  5. Fix the messge to something like "fix: valid commit", you should see the commit succeed.
jrw421 commented 3 years ago

Think this may need to be updated with trunk because of the build failure.

Akarshit commented 3 years ago

@jrw421 It was an issue with me using npm instead of yarn