search

reactioncommerce / example-storefront

Example Storefront is Reaction Commerce’s headless ecommerce storefront - Next.js, GraphQL, React. Built using Apollo Client and the commerce-focused React UI components provided in the Storefront Component Library (reactioncommerce/reaction-component-library). It connects with Reaction backend with the GraphQL API.
https://www.mailchimp.com/developer/open-commerce
Apache License 2.0
608 stars 288 forks source link

Adds projectType to package.json (used to auto detect project type in CLI) #822

Closed sujithvn closed 2 years ago

sujithvn commented 2 years ago

Signed-off-by: Sujith sujith@merchstack.com

Resolves reactioncommerce/cli#25 Impact: minor Type: feature

Issue

A new property "projectType": "storefront-example" is required by the CLI to autoDetect the projectType when the user has not provided it as an argument.

Solution

Added a new property to package.json which would identify the project type. "projectType": "storefront-example" While issuing 'develop' command, we check if the projectType is provided by user as args and use it if present. Else we check for the newly introduced projectType property in package.json. If not found or if invalid, we throw error and exit.

Breaking changes

None.

Testing

Tested both cases of executing develop command with and without projectType argument - pass Tested case where there is no projectType entry in package.json - pass Tested case where there is invalid projectType entry in package.json - pass