search

reactioncommerce / federated-gateway

An access aware federated GraphQL API gateway for the Reaction Commerce ecosystem
Apache License 2.0
6 stars 3 forks source link

refactor: moved services #37

Closed rosshadden closed 3 years ago

rosshadden commented 4 years ago

This started as a branch where I was working with directives, but I moved that stuff away. What remained were minor filesystem changes.

rosshadden commented 4 years ago

@kieckhafer Our docs say to use dashes and avoid camel casing filenames, which is good practice because not all filesystems are case-sensitive (Windows NTFS for example). I think Reaction is one of the only one of our projects that breaks this rule, but maybe the storefront as well.

Linting failing is weird because it works locally, including if I run the same hadolint lint-javascript script that CI runs.

mikemurray commented 4 years ago

@rosshadden I think that document is an old recommendation on naming conventions. We currently match the name of the file to the exported function or component. This usually results in camel or capital-cased file names. I think the doc should be updated and maybe have a DR/updated for it.

Akarshit commented 3 years ago

Closing because of age.