reactioncommerce / kinetic

Kinetic introduces a suite of opinionated admin tools that internal teams can use to manage and run their stores on Open Commerce.
Apache License 2.0
7 stars 3 forks source link

Prepare error handler component #117

Closed vannguyenn closed 1 year ago

vannguyenn commented 1 year ago

This PR is an improvement for our error handler. Most of the time we should handle errors properly, but in some cases like Network errors or any unexpected error we should notify users and handle them properly instead of displaying an empty page.

Testing Instructions:

image
brent-hoover commented 1 year ago

I feel like the message "Network Error" just because it can't reach the API server might cause a little confusion. Could be nothing to do with Network and just the server is down. Should be make it more clear that the issue is reaching the API server?

vannguyenn commented 1 year ago

Thanks, @zenweasel, I will update the error message.