reactioncommerce / kinetic

Kinetic introduces a suite of opinionated admin tools that internal teams can use to manage and run their stores on Open Commerce.
Apache License 2.0
7 stars 3 forks source link

As an operator I want to Trigger a promotion based on an Item in the cart #138

Closed brendan-shea-pm closed 1 year ago

brendan-shea-pm commented 1 year ago

Mockup (Promotions / Detail / Item Trigger) https://www.figma.com/file/vWot2cXXgjcsLpMq4SAX90/Kinetic?node-id=2020%3A54523&t=c9z0pplx66ozEPgb-0

Screenshot 2022-12-11 at 2 19 57 PM Screenshot 2022-12-11 at 2 22 21 PM

vanpho93 commented 1 year ago

BE current does not support this yet, instead of checking if the cart contains some items, we can say required value of some items is bigger than a certain amount, can be bigger than 0.

so it's just the same as this one "As an operator I want to be able to trigger a promotion based on the value of the cart" but the amount required is 0.

https://app.zenhub.com/workspaces/moc-main-board-62fd8e881686130027eafc31/issues/gh/reactioncommerce/kinetic/119

vanpho93 commented 1 year ago

Update:

We added another field totalItemCount before, so we can do this feature with totalItemCount > 0. Quite funny because I added this field just for demonstration but turns out we actually need it.

vannguyenn commented 1 year ago

Hi @brendan-shea-pm, do you want to add a numeric field beside this field to have the ability to add a number amount of items in the cart? Something like this. image.png

brendan-shea-pm commented 1 year ago

@vannguyenn Yes that works. Could you add text to the left of the number field that reads "Number of items required in cart" so that it's clear what the number field represents?

vannguyenn commented 1 year ago

@brendan-shea-pm Sure will do. Thanks

vannguyenn commented 1 year ago

Hi @brendan-shea-pm Regarding the field label, I think we should do something like this for consistency and a better layout. WDYT? Screenshot 2023-01-10 at 15.41.30.pngScreenshot 2023-01-10 at 15.41.40.png

brendan-shea-pm commented 1 year ago

@vannguyenn Yes that is a more elegant solution, thanks! Is there some way to indicate that this is the minimum number of items required? Want to make sure the user understands that it is ItemCount equal to or great than the number. So if a user puts 1 but the customer has 2 then the promo is still triggered.

vannguyenn commented 1 year ago

@brendan-shea-pm We can have a description under the field, our TextField component supports this image.png

brendan-shea-pm commented 1 year ago

@vannguyenn Yes I like it! Can we say "Minimum number of items required to trigger promotion"

vannguyenn commented 1 year ago

Sure, will update it