Enable/Disable promotions

reactioncommerce / kinetic

Kinetic introduces a suite of opinionated admin tools that internal teams can use to manage and run their stores on Open Commerce.

Apache License 2.0

7 stars 3 forks source link

Enable/Disable promotions #139

Closed vannguyenn closed 1 year ago

vannguyenn commented 1 year ago

Resolves #131 , #130, #123

Testing Instructions:

Use branch feat/promotions on API to test this feature
Start the app and login with a valid account
Navigate to Promotions
Navigate to Disabled tab, select one promotion and click Actions/Enable
Or navigate to a promotion details page, click Actions/Enable

brent-hoover commented 1 year ago

When I disable a promotion the toast that pops up says "Disable promotion successfully" but it should say "Disabled promotion successfully". Just the verb tense is wrong. Same with Enable/Enabled

brent-hoover commented 1 year ago

I saw the same behavior as Ted, can't Enable a disabled promotion that was once active from the detail view. Was able to enable it again from the Table view.

brent-hoover commented 1 year ago

Verified this issue is resolved:

I was able to enable and disable promotion except I was not able to disable an active promotion. The dropdown only showed "Duplicate"

brent-hoover commented 1 year ago

If I try to enable an archived promotion it does not work but it does not give me any sort of error message

tedraykov commented 1 year ago

A problem not related to the PR, but when the API is down, the error page has regressed:

I got an infinite spinner.

tedraykov commented 1 year ago

Here is a problem identified and i'm not sure if I'm doing something wrong, but seems like a bug https://www.loom.com/share/d465ae9788ee4f81a012aa6d2fc74b99

vannguyenn commented 1 year ago

Thanks @tedraykov, that's a bug when disabling a promotion. I have updated the PR