reactioncommerce / kinetic

Kinetic introduces a suite of opinionated admin tools that internal teams can use to manage and run their stores on Open Commerce.
Apache License 2.0
7 stars 3 forks source link

Promotion Coupons #167

Closed vannguyenn closed 1 year ago

vannguyenn commented 1 year ago

Resolves #142, #145, #144, #146

Testing Instructions:

Screenshot 2023-01-17 at 13 15 40 Screenshot 2023-01-17 at 13 16 12 Screenshot 2023-01-17 at 13 15 51
tedraykov commented 1 year ago

@vannguyenn I'm getting the following error when trying to create a coupon:

Screenshot 2023-01-18 at 13 16 25
mutation.js:106 Error: canUseInStore is not allowed by the schema: {"response":{"errors":[{"message":"canUseInStore 
is not allowed by the schema","locations":[{"line":3,"column":3}],"path":["createPromotion"],"extensions":
{"code":"BAD_USER_INPUT","exception":{"errorType":"ClientError","name":"ClientError","error":"validation-error",
"details":[{"name":"canUseInStore","type":"keyNotInSchema","value":false,"message":"canUseInStore 
is not allowed by the schema"}],"stacktrace":["ClientError: canUseInStore is not allowed by the schema"

Am i on a wrong branch of the API or something? I'm using the latest from feat/promotions

vannguyenn commented 1 year ago

@tedraykov yes, this PR is not ready for review yet. I'm waiting for some changes from the API

vannguyenn commented 1 year ago

Move to blocked while waiting for API changes from Brian

brent-hoover commented 1 year ago

@vannguyenn can you clarify what changes you are waiting for and that you are working against the coupons branch?

vannguyenn commented 1 year ago

@zenweasel I just integrated this PR with the delete coupon API. Please help to review the missing cases when you have time. Thanks

brent-hoover commented 1 year ago

Issue with deletion of coupon triggers resolved