As an operator I want to set start and end times for my promotion, in addition to start and end dates

reactioncommerce / kinetic

Kinetic introduces a suite of opinionated admin tools that internal teams can use to manage and run their stores on Open Commerce.

Apache License 2.0

7 stars 3 forks source link

As an operator I want to set start and end times for my promotion, in addition to start and end dates #174

Closed vannguyenn closed 1 year ago

vannguyenn commented 1 year ago

Resolves #161

Testing Instructions:

Start the app and login with a valid account
Navigate to Promotions
Click on one promotion row to go to a Promotion details page
Scroll down to Promotion Scheduling section
Select start date and time

brent-hoover commented 1 year ago

Before testing this I corrected the issue on the API where it was only accepting Date rather than DateTime. The PR is here

Seeing something strange where I set it for one time in the UI and gets set for a different date in the db:

Not sure what's happening there but seems similar to the issue that @node82 was running into. I am using mostly unchanged Sample Data set.

vannguyenn commented 1 year ago

@zenweasel This is expected, the time shown in the UI is based on your local time, then when sending to the API it will be transformed into UTC+0 with the expected date time format. Then we can easily combine this time with the store's timezone to calculate the schedule

vannguyenn commented 1 year ago

@tedraykov I updated the PR. Please review again when you have time. Thanks