Add additional message fields to promotion

reactioncommerce / kinetic

Kinetic introduces a suite of opinionated admin tools that internal teams can use to manage and run their stores on Open Commerce.

Apache License 2.0

7 stars 3 forks source link

Add additional message fields to promotion #190

Closed vannguyenn closed 1 year ago

vannguyenn commented 1 year ago

Resolves #175 #176 Related changes on API: https://github.com/reactioncommerce/reaction/pull/6788

Testing Instructions:

Start the app and login with a valid account
Navigate to Promotions
Click on one promotion row to go to a Promotion details page
Scroll down to Promotion Message section

tedraykov commented 1 year ago

Not related to this PR's changes but when I try to create a promotion without setting the Max $ discount on an order, I don't get a form field validation error in the UI, but we still get a response error that the field is required.

This may be fixed in the rest of the PRs but I want to add a note here so we don't miss this out if it isn't handled.

vannguyenn commented 1 year ago

Thanks @tedraykov, issues with promotion limit usages will be fixed in another PR