search

reactioncommerce / kinetic

Kinetic introduces a suite of opinionated admin tools that internal teams can use to manage and run their stores on Open Commerce.
Apache License 2.0
7 stars 3 forks source link

Login screen references "Sign up" option that does not appear anywhere #77

Closed brent-hoover closed 1 year ago

brent-hoover commented 2 years ago

If you enter an account that does not exist I get this message, however I am unable to locate a "Sign Up" option image.png

vannguyenn commented 2 years ago

Hi @brendan-shea-pm Could you advise me about the error message here? Currently, we're using the Create your first shop link as a way to sign up for an account. Should we change it to Sign up or should we update the error message? Thank you

brendan-shea-pm commented 2 years ago

Hi @vannguyenn We should add a "Sign Up" button below Sign In so that users have a way to create an account if they don't have one. In terms of the button style, if possible we should have a green (matching the Sign In green) stroke and green text, but the button should have a white background to differentiate it from the Sign In button.

If that is not possible, please use the Cancel button style as the model and just change the text to "Sign Up"

vannguyenn commented 2 years ago

Got you. Should we also remove the text Don't have a shop? Create your first shop? Because we will use the Sign Up button to register an account.

brendan-shea-pm commented 2 years ago

Let's keep "Don't have a shop? Create your first shop" the way it is now. It's a good call to action if someone is specifically looking to create a shop.

vannguyenn commented 2 years ago

Hi @brendan-shea-pm , so I have 2 versions when adding the "Sign Up" button, what's your preference? The second version is similar to what we're having with the sign-up form. Thanks Screen Shot 2022-10-24 at 16.52.41.pngScreen Shot 2022-10-24 at 16.56.47.png

brendan-shea-pm commented 2 years ago

Great, thanks! The second one feels cleaner and more direct, Let's go with that one. Two minor adjustments to format it to match the top sentence:

Change "Don't have an account" text color to black

Change "Sign Up" to bold text, leave it green

On Mon, Oct 24, 2022, 6:02 AM Chloe @.***> wrote:

Hi @brendan-shea-pm https://github.com/brendan-shea-pm , so I have 2 versions when adding the "Sign Up" button, what's your preference? The second version is similar to what we're having with the sign-up form. Thanks [image: Screen Shot 2022-10-24 at 16.52.41.png] https://camo.githubusercontent.com/77e12bff9ac9d0d869844972402610ba28a58a733d8a173817903394eb56c2bf/68747470733a2f2f696d616765732e7a656e68756275736572636f6e74656e742e636f6d2f3633313539626462383739643635643833323765346565332f39613665666137632d643731662d346163632d383636662d623933343833376535336161[image: Screen Shot 2022-10-24 at 16.56.47.png] https://camo.githubusercontent.com/b06d0b8ffa100e7f9ece6c6554fa0e47ecfaa7a3eb8feecbec42c96f235de196/68747470733a2f2f696d616765732e7a656e68756275736572636f6e74656e742e636f6d2f3633313539626462383739643635643833323765346565332f37343730376535652d313564352d343832322d613062642d633061633563663162383233

— Reply to this email directly, view it on GitHub https://github.com/reactioncommerce/kinetic/issues/77#issuecomment-1288769049, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATONCOOYNWQBFWALMIPW7P3WEZNEPANCNFSM6AAAAAARD2OZZ4 . You are receiving this because you were mentioned.Message ID: @.***>