Open Merkg9 opened 2 years ago
@zenweasel I believe this can be closed as it was fixed back in march.
@dcrdev check this file: templates/web/web-deployment.yaml ImagePullSecrets must be in deployment spec. Not spec.containers
@Merkg9 you are correct, I missed that this was in the storefront deployment rather than the api deployment
@dcrdev Is this PR ok to merge?
@dcrdev Is this PR ok to merge?
Yup you can merge this
@Merkg9 Thanks for the fix. Can you update your DCO? You can see the instructions here
Then we can go ahead and merge
Error: INSTALLATION FAILED: YAML parse error on opencommerce/templates/web/web-deployment.yaml: error converting YAML to JSON: yaml: line 31: did not find expected key