Resolve bug in spec section

reactioncommerce / mailchimp-open-commerce-helm-chart

Helm chart for deploying Mailchimp Open Commerce ontop of Kubernetes/Openshift.

Apache License 2.0

3 stars 4 forks source link

Resolve bug in spec section #37

Open Merkg9 opened 2 years ago

Merkg9 commented 2 years ago

Error: INSTALLATION FAILED: YAML parse error on opencommerce/templates/web/web-deployment.yaml: error converting YAML to JSON: yaml: line 31: did not find expected key

dcrdev commented 2 years ago

@zenweasel I believe this can be closed as it was fixed back in march.

Merkg9 commented 2 years ago

@dcrdev check this file: templates/web/web-deployment.yaml ImagePullSecrets must be in deployment spec. Not spec.containers

dcrdev commented 2 years ago

@Merkg9 you are correct, I missed that this was in the storefront deployment rather than the api deployment

brent-hoover commented 2 years ago

@dcrdev Is this PR ok to merge?

dcrdev commented 2 years ago

@dcrdev Is this PR ok to merge?

Yup you can merge this

brent-hoover commented 2 years ago

@Merkg9 Thanks for the fix. Can you update your DCO? You can see the instructions here

Then we can go ahead and merge